Skip to content

Conversation

@clarasb
Copy link
Collaborator

@clarasb clarasb commented Nov 25, 2025

This PR updates vega to v6 and its corresponding dependencies.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.17%. Comparing base (63037e1) to head (e4426f8).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   92.71%   92.17%   -0.54%     
==========================================
  Files          86       86              
  Lines        1496     1496              
  Branches      225      225              
==========================================
- Hits         1387     1379       -8     
- Misses         91       98       +7     
- Partials       18       19       +1     
Flag Coverage Δ
backend 100.00% <100.00%> (ø)
frontend 83.75% <ø> (-1.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clarasb clarasb marked this pull request as ready for review November 27, 2025 15:08
@clarasb clarasb requested review from b-yogesh and forman and removed request for b-yogesh November 27, 2025 15:08
Copy link
Collaborator

@b-yogesh b-yogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look/respond to my comment. Does it works fine with xcube-viewer too? There is one test for VegaChart that is missing in the Github CI, is that intentional?

@clarasb clarasb requested a review from b-yogesh November 28, 2025 09:13
@clarasb clarasb merged commit 3403cfd into main Nov 28, 2025
9 checks passed
@clarasb clarasb deleted the clarasb-xxx-update_vega branch December 3, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants